mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72099: Removed code for tracking pending tasks.
Date Wed, 12 Feb 2020 18:00:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72099/
-----------------------------------------------------------

(Updated Feb. 12, 2020, 6 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

Deprecated `pending_tasks` in `master.proto`


Bugs: MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

Now that ACCEPT is authorized synchronously, there are no pending
tasks in-between dispatches on `Master` methods, thus the pending task
tracking code is not needed anymore.


Diffs (updated)
-----

  include/mesos/master/master.proto 8c22802625c80c7fcd64d947b693ab4f5d069142 
  include/mesos/v1/master/master.proto 40de3580681fbb066d8f49c5df8d0c97cd766703 
  src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 
  src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f 
  src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e 
  src/master/readonly_handler.cpp 40005a2ac2cc9dd6075425c184d220f0a2fbee99 
  src/master/validation.hpp b2897132a6bfaa1002663d6aea0fb87246b3d8d8 
  src/master/validation.cpp 2f80536dd3810180385351765965ed6211d372c7 
  src/tests/master_validation_tests.cpp e92ff5913ea43f50b0895d7a2b2dd0efd7361083 


Diff: https://reviews.apache.org/r/72099/diff/2/

Changes: https://reviews.apache.org/r/72099/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message