mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Date Tue, 11 Feb 2020 23:06:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72116/#review219552
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72116]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Feb. 11, 2020, 8:54 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72116/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2020, 8:54 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-10094
>     https://issues.apache.org/jira/browse/MESOS-10094
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The code was incorrectly printing the framework count, since these
> are hashmap<FrameworkID, hashmap<TaskID, Task>>.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e 
> 
> 
> Diff: https://reviews.apache.org/r/72116/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message