mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Date Tue, 11 Feb 2020 18:29:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72114/#review219546
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72114]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Feb. 11, 2020, 4:38 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72114/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2020, 4:38 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These changes are needed to get the tests to run.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 838aaee0b921b1b59d4e2b2fb69d861eec95ba56 
>   src/slave/slave.cpp 75bf59566a327a05cf7e763409b60f30e9432c86 
>   src/tests/command_executor_tests.cpp 73f80063631f1d004be307fdce77d1b405468e14 
> 
> 
> Diff: https://reviews.apache.org/r/72114/diff/1/
> 
> 
> Testing
> -------
> 
> `cmake --build . --target tests`
> `src\mesos-tests.exe`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message