mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 72107: Fixed Windows command argument stringification.
Date Tue, 11 Feb 2020 09:06:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72107/#review219538
-----------------------------------------------------------




3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 218 (patched)
<https://reviews.apache.org/r/72107/#comment307729>

    Please add a test for this.



3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 219-223 (patched)
<https://reviews.apache.org/r/72107/#comment307728>

    This is a strange loop and it took me a while to digest.
    
    Could we instead just perform the escaping inside the loop above where we already perform
some escaping? You could even introduce a small helper if you wanted.


- Benjamin Bannier


On Feb. 11, 2020, 9:54 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72107/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2020, 9:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Bugs: MESOS-10093
>     https://issues.apache.org/jira/browse/MESOS-10093
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed Windows command argument stringification.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 2f76bbaac9032906c544010c55cdcbe3d7b03d23

> 
> 
> Diff: https://reviews.apache.org/r/72107/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually by launching a docker task with the following command:
> 
> ```
> python -c "import time\nwhile True:\n    time.sleep(5)\n    print('hello world')"
> ```
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message