mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Date Fri, 07 Feb 2020 20:18:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72093/#review219528
-----------------------------------------------------------



I'm a bit confused by this one, the existing method already has action in the template parameters,
what does this accomplish? An explanation and maybe an example code snippet in the description
would be helpful for the reader

- Benjamin Mahler


On Feb. 7, 2020, 5:32 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72093/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2020, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10056
>     https://issues.apache.org/jira/browse/MESOS-10056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is needed to use `ObjectApprovers` for authorizing scheduler API
> calls.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 5fc19fdd16138eb4c7d14fd29b1a56a53f6323a9 
> 
> 
> Diff: https://reviews.apache.org/r/72093/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message