mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Date Wed, 05 Feb 2020 03:22:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72080/#review219503
-----------------------------------------------------------


Fix it, then Ship it!




It seems this test will take 10+ seconds:
```
[ RUN      ] DockerFetcherPluginTest.INTERNET_CURL_GeneratedRepositoryScope
sh: hadoop: command not found
I0205 02:02:23.218667  5865 fetcher.cpp:68] Skipping URI fetcher plugin 'hadoop' as it could
not be created: Failed to create HDFS client: Hadoop client is not available, exit status:
32512
W0205 02:02:23.721199  5871 docker.cpp:1175] Missing 'realm', 'service' or 'scope' in header
WWW-Authenticate: Bearer realm="https://nvcr.io/proxy_auth?scope=repository:nvidia/k8s/cuda-sample:pull,push"
[       OK ] DockerFetcherPluginTest.INTERNET_CURL_GeneratedRepositoryScope (12176 ms)
```

It is a bit too long, is there a way to accelerate it?


src/tests/uri_fetcher_tests.cpp
Lines 416-417 (patched)
<https://reviews.apache.org/r/72080/#comment307703>

    A newline between.



src/tests/uri_fetcher_tests.cpp
Lines 422-423 (patched)
<https://reviews.apache.org/r/72080/#comment307704>

    Need 2 more spaces for indent.


- Qian Zhang


On Feb. 4, 2020, 8:01 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72080/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2020, 8:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10092
>     https://issues.apache.org/jira/browse/MESOS-10092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for fetch from repositories not providing scope/service.
> 
> 
> Diffs
> -----
> 
>   src/tests/uri_fetcher_tests.cpp 92f80626f4de8a2cc29760366ca568f9d794f472 
> 
> 
> Diff: https://reviews.apache.org/r/72080/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message