mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Date Wed, 05 Feb 2020 03:05:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72079/#review219502
-----------------------------------------------------------


Fix it, then Ship it!





src/uri/fetchers/docker.hpp
Lines 52 (patched)
<https://reviews.apache.org/r/72079/#comment307700>

    Can we do `bool enableAuthServiceUriFallback = true` instead? Double negative seems a
bit odd to me.



src/uri/fetchers/docker.cpp
Line 488 (original), 500 (patched)
<https://reviews.apache.org/r/72079/#comment307701>

    Need a space behind `from`.



src/uri/fetchers/docker.cpp
Lines 1151-1152 (patched)
<https://reviews.apache.org/r/72079/#comment307702>

    I think we do not need `from initialUri` which should already be included in `authParam.error()`.


- Qian Zhang


On Feb. 4, 2020, 9:24 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72079/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2020, 9:24 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10092
>     https://issues.apache.org/jira/browse/MESOS-10092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a fallback Docker authorization server URI generation
> mechanism (see MESOS-10092) for repository servers that provide no
> "scope"/"service" params in the "WWW-Authenticate" header of the initial
> "401 Unathorized" response.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 
>   src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874 
> 
> 
> Diff: https://reviews.apache.org/r/72079/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message