mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Date Tue, 04 Feb 2020 12:05:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72079/
-----------------------------------------------------------

(Updated Feb. 4, 2020, 12:05 p.m.)


Review request for mesos, Andrei Budnik and Qian Zhang.


Changes
-------

Addressed issues.
Added a flag for disabling the fallback in tests (to be able to make sure that the registry
used for testing purposes triggers the fallback logic).


Bugs: MESOS-10092
    https://issues.apache.org/jira/browse/MESOS-10092


Repository: mesos


Description
-------

This patch adds a fallback Docker authorization server URI generation
mechanism (see MESOS-10092) for repository servers that provide no
"scope"/"service" params in the "WWW-Authenticate" header of the initial
"401 Unathorized" response.


Diffs (updated)
-----

  src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 
  src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874 


Diff: https://reviews.apache.org/r/72079/diff/2/

Changes: https://reviews.apache.org/r/72079/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message