mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Date Tue, 04 Feb 2020 09:30:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72080/#review219482
-----------------------------------------------------------




src/tests/uri_fetcher_tests.cpp
Lines 398 (patched)
<https://reviews.apache.org/r/72080/#comment307660>

    IIUC, `nvcr.io` is the registry, instead `nvidia/k8s/cuda-sample:nbody` is the repository.



src/tests/uri_fetcher_tests.cpp
Lines 399 (patched)
<https://reviews.apache.org/r/72080/#comment307661>

    How do we know it does not provide scope on its own and our code logic for generating
repository scope is hit? I think we need to verify it in the test.


- Qian Zhang


On Feb. 4, 2020, 1:54 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72080/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2020, 1:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10092
>     https://issues.apache.org/jira/browse/MESOS-10092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for fetch from repositories not providing scope/service.
> 
> 
> Diffs
> -----
> 
>   src/tests/uri_fetcher_tests.cpp 92f80626f4de8a2cc29760366ca568f9d794f472 
> 
> 
> Diff: https://reviews.apache.org/r/72080/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message