mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72078: Factored out getting authorization server URI.
Date Tue, 04 Feb 2020 06:56:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72078/#review219478
-----------------------------------------------------------




src/uri/fetchers/docker.cpp
Line 1071 (original), 1071 (patched)
<https://reviews.apache.org/r/72078/#comment307643>

    This static method should be moved to the beginning of this file.



src/uri/fetchers/docker.cpp
Lines 1136-1137 (patched)
<https://reviews.apache.org/r/72078/#comment307644>

    A newline between.



src/uri/fetchers/docker.cpp
Lines 1122-1147 (original), 1139-1165 (patched)
<https://reviews.apache.org/r/72078/#comment307646>

    Need two spaces indent for this whole block.


- Qian Zhang


On Feb. 4, 2020, 1:54 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72078/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2020, 1:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10092
>     https://issues.apache.org/jira/browse/MESOS-10092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Factored out getting authorization server URI.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874 
> 
> 
> Diff: https://reviews.apache.org/r/72078/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message