mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72070: Fixed the build on Windows.
Date Mon, 03 Feb 2020 05:47:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72070/#review219462
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Jan. 31, 2020, 9:56 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72070/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2020, 9:56 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-10090
>     https://issues.apache.org/jira/browse/MESOS-10090
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The addition of executor domain socket support broke the build on
> Windows. This patch updates preprocessor directives in order to fix
> the build.
> 
> 
> Diffs
> -----
> 
>   src/executor/executor.cpp 7cff25845176f0fc893ebb708e7a16974a51681f 
>   src/launcher/default_executor.cpp 4369fd0052b2e8496ba63606fa57e17d881ea52c 
>   src/local/local.cpp 6a7709de33908eed08dae3a0b8eb2a31dcd7b482 
>   src/slave/flags.cpp 7653c397cbf27490f7b071b5e151bcdf77e6478c 
>   src/slave/main.cpp b5715d9f14a7d64ed0b82082bf7d04b97a48cfe4 
>   src/slave/slave.hpp 38448672747f82f2b7ee72aef50cb8eac08f1e8b 
>   src/slave/slave.cpp 4c3d4715538742c84c060f5b197eaaae0e561793 
>   src/tests/cluster.cpp ffb7161ed91c4b5b7a200bbca79e3be4b767cebe 
>   src/tests/mock_slave.cpp dfbca2a01083072f68d30d6867fb3f487be5ec16 
> 
> 
> Diff: https://reviews.apache.org/r/72070/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` macos/Linux; `make tests` msvc
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message