mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71931: Added the `share_cgroups` field into `LinuxInfo`.
Date Fri, 20 Dec 2019 12:39:04 GMT


> On Dec. 20, 2019, 5:02 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 3362 (patched)
> > <https://reviews.apache.org/r/71931/diff/1/?file=2190845#file2190845line3362>
> >
> >     Do you think we should do `share_cgroups` instead of `shared_cgroups`, to be
consistent with the name of the `share_pid_namespace` field?

Agree.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71931/#review219078
-----------------------------------------------------------


On Dec. 20, 2019, 8:38 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71931/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2019, 8:38 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10075
>     https://issues.apache.org/jira/browse/MESOS-10075
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the `share_cgroups` field into `LinuxInfo`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5 
>   include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c 
> 
> 
> Diff: https://reviews.apache.org/r/71931/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message