mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71908: Updated protobuf -> JSON mapping to emit empty repeated fields / maps.
Date Fri, 13 Dec 2019 03:48:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71908/#review219022
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71906, 71907, 71908]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Dec. 12, 2019, 11:12 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71908/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2019, 11:12 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Greg Mann.
> 
> 
> Bugs: MESOS-6568
>     https://issues.apache.org/jira/browse/MESOS-6568
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per MESOS-6568, the omission of empty repeated fields / maps is
> inconsistent with the standard proto3 -> JSON mapping. An empty
> array is also more convenient to program against since you don't
> need to special case the empty case with an absence check.
> 
> This may break any tests that rely on exact string outputs, but
> it generally should not break any logic.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp c5b2a91958c870e272895520ba04fc5287891c3c 
> 
> 
> Diff: https://reviews.apache.org/r/71908/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message