mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71882: Added a stout function to compute relative paths.
Date Mon, 09 Dec 2019 12:09:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71882/#review218976
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/path.hpp
Lines 21 (patched)
<https://reviews.apache.org/r/71882/#comment306963>

    This doesn't seem to be necessary anymore?



3rdparty/stout/include/stout/path.hpp
Lines 551 (patched)
<https://reviews.apache.org/r/71882/#comment306967>

    I found the description below easier to parse:
    
    > Relative paths can only be computed between paths which are either both absolute
or both relative.



3rdparty/stout/include/stout/path.hpp
Lines 556 (patched)
<https://reviews.apache.org/r/71882/#comment306964>

    I personally don't really mind, but our styleguide doesn't seem to like this:
    
    > Some trailing underscores are used to distinguish between similar variables in the
same scope (think prime symbols), but this should be avoided as much as possible, including
removing existing instances in the code base.



3rdparty/stout/include/stout/path.hpp
Lines 590 (patched)
<https://reviews.apache.org/r/71882/#comment306966>

    How about
    
        the range of `base`
        
        the `base` range
        
        the range `[base.begin(), base.end())`
        
    to avoid the awkward backtick-single-quote?


- Benno Evers


On Dec. 5, 2019, 12:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71882/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2019, 12:49 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-10062
>     https://issues.apache.org/jira/browse/MESOS-10062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a stout function to compute relative paths.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp ba1f665ce94b9636d88a7ecce8643c56758f7b5c 
>   3rdparty/stout/tests/path_tests.cpp 19dd910a534040468aeb48f15ebdf56dff32bc15 
> 
> 
> Diff: https://reviews.apache.org/r/71882/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message