mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71833: Created unix domain socket on agent startup.
Date Thu, 05 Dec 2019 15:12:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71833/#review218939
-----------------------------------------------------------




src/slave/main.cpp
Lines 614 (patched)
<https://reviews.apache.org/r/71833/#comment306915>

    Same comments as in `tests/cluster.cpp` below.



src/tests/cluster.cpp
Lines 613-614 (patched)
<https://reviews.apache.org/r/71833/#comment306918>

    Either implement this `TODO` before landing or explicitly reference the code you added
above.



src/tests/cluster.cpp
Lines 630 (patched)
<https://reviews.apache.org/r/71833/#comment306917>

    There is another, currently unhandled branch where `domain_socket_location` exists, but
is not a socket. Either we handle that case as well, or just check if _something_ exists where
we'd expect the socket and  let this fail later.



src/tests/cluster.cpp
Lines 653-654 (patched)
<https://reviews.apache.org/r/71833/#comment306914>

    This should be implemented when this patch lands, or be less terse.



src/tests/cluster.cpp
Lines 656 (patched)
<https://reviews.apache.org/r/71833/#comment306913>

    Is this outdated? I think we want to log whether we created a new file or used an existing
socket, and indicate whether we successfully did `bind` a socket at that path.


- Benjamin Bannier


On Dec. 3, 2019, 7:30 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71833/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2019, 7:30 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-10036
>     https://issues.apache.org/jira/browse/MESOS-10036
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent code to check whether domain socket support is
> enabled, and if so to create or open the socket at
> MESOS_DOMAIN_SOCKET_LOCATION.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 8ff43618f06463b4ba86b64b25e5de692e406448 
>   src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 
>   src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb 
>   src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 
>   src/tests/cluster.cpp f7bc882a644ec65710ada3d15507e1d4c5ba06f7 
>   src/tests/mock_slave.cpp 71be957884ea88258ef37e60649e3947e89b12d0 
> 
> 
> Diff: https://reviews.apache.org/r/71833/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message