mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71862: Moved creating authorization Object out of `Master::authorize*Disk`.
Date Wed, 04 Dec 2019 19:52:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71862/#review218919
-----------------------------------------------------------



So much code deleted! :)


src/master/authorization.hpp
Lines 71 (patched)
<https://reviews.apache.org/r/71862/#comment306839>

    Don't forget to end with a period! (ditto for the one right below it)



src/master/authorization.cpp
Lines 140 (patched)
<https://reviews.apache.org/r/71862/#comment306841>

    This seems like a case where we should not use `default`, so that if we add a new disk
type the compiler complains about this switch and we have to consider authz.



src/master/authorization.cpp
Lines 150-151 (patched)
<https://reviews.apache.org/r/71862/#comment306840>

    Ditto from previous reviews, doesn't this style of construction copy the ActionObject?
It's something I'm curious about, can't easily see how the copy is avoided



src/master/authorization.cpp
Lines 168 (patched)
<https://reviews.apache.org/r/71862/#comment306842>

    Ditto here w.r.t. default.



src/master/master.cpp
Line 4872 (original), 4734 (patched)
<https://reviews.apache.org/r/71862/#comment306832>

    Don't forget, two space indent if not wrapping an open paren!



src/master/master.cpp
Line 4884 (original), 4747 (patched)
<https://reviews.apache.org/r/71862/#comment306833>

    Ditto here


- Benjamin Mahler


On Dec. 3, 2019, 5:53 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71862/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2019, 5:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10023 and MESOS-10056
>     https://issues.apache.org/jira/browse/MESOS-10023
>     https://issues.apache.org/jira/browse/MESOS-10056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved creating authorization Object out of `Master::authorize*Disk`.
> 
> 
> Diffs
> -----
> 
>   src/master/authorization.hpp PRE-CREATION 
>   src/master/authorization.cpp PRE-CREATION 
>   src/master/master.hpp 93630421d58e6fd26566e81a23cd910957795665 
>   src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 
> 
> 
> Diff: https://reviews.apache.org/r/71862/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message