mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71823: Simplified V0 -> V1 direct serialization logic.
Date Tue, 03 Dec 2019 04:13:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71823/
-----------------------------------------------------------

(Updated Dec. 3, 2019, 4:13 a.m.)


Review request for mesos, Andrei Sekretenko and Greg Mann.


Changes
-------

* Moved WireFormatLiteWrapper up to protobuf utils as WireFormatLite2.


Bugs: MESOS-10026
    https://issues.apache.org/jira/browse/MESOS-10026


Repository: mesos


Description
-------

There are higher level utility functions that can be used to make
the code simpler and less error prone.

Also, while not a bug, we should be using WriteBytes instead of
WriteString for writing submessage bytes.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp 93ee42a3662a4844846919c0e020d76bc9702510 
  src/master/http.cpp e03655863ea2d4e4464b3d14b359de3d7f059778 


Diff: https://reviews.apache.org/r/71823/diff/2/

Changes: https://reviews.apache.org/r/71823/diff/1-2/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message