mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71816: WIP: Added domain-socket related flags to Mesos agent.
Date Thu, 28 Nov 2019 14:28:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71816/#review218848
-----------------------------------------------------------




src/slave/flags.cpp
Lines 992 (patched)
<https://reviews.apache.org/r/71816/#comment306740>

    We also need to validate that the path is less than 108 characters long.


- Benno Evers


On Nov. 25, 2019, 5 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71816/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2019, 5 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-10035
>     https://issues.apache.org/jira/browse/MESOS-10035
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added two new flags `http_executor_domain_sockets` and
> `domain_socket_location` to the agent, along with minimal
> logic to pass the relevant values on to executors.
> 
> They are used to control whether the agent should
> provide a domain socket to HTTP executors and the
> location of the socket on the host filesystem, respectively.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 3c5ffca62454c340656cfc89c53a198757815794 
>   src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 
>   src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 
> 
> 
> Diff: https://reviews.apache.org/r/71816/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message