mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.
Date Wed, 20 Nov 2019 00:29:10 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 19, 2019, 4:29 p.m.)

Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.


* Added a "compute_thread" so that calls to `SSL_read` and `SSL_write` can be spread onto
(many) libprocess worker threads rather than the (one) event loop thread.
* Changed shutdown to happen asynchronously but accept dirty shutdowns.
* Guarded against new send/recv calls after shutdown.

Bugs: MESOS-10010

Repository: mesos


This completes a fully functional client-side SSL socket.

Needs a bit of cleanup and more error handling though.

Diffs (updated)

  3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 



Testing (updated)

cmake --build . --target libprocess-tests

Running libprocess-tests yields:
[  FAILED  ] SSLTest.ValidDowngrade
[  FAILED  ] SSLTest.ValidDowngradeEachProtocol


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message