mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xudong Ni via Review Board <>
Subject Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered
Date Tue, 19 Nov 2019 22:39:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 19, 2019, 10:39 p.m.)

Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Addressed the comments except the test which will be updated later

Bugs: MESOS-10032

Repository: mesos


In the case agents lost ZooKeeper connections and resetting its
master to none and beginning to dropping control messages from the
master, agent should not respond pings from master.

Diffs (updated)

  src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 




==========] 2322 tests from 222 test cases ran. (1038166 ms total)
[  PASSED  ] 2321 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SlaveRecoveryTest/0.PingTimeoutDuringRecovery, where TypeParam = mesos::internal::slave::MesosContainerizer

This failed test verifies that the agent responds to pings from the master while the agent
is performing recovery, this PR will break this scenario.


Xudong Ni

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message