mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <>
Subject Re: Review Request 71734: Revamped attribute handling in stout.
Date Thu, 07 Nov 2019 14:23:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 7, 2019, 2:23 p.m.)

Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.


Incorporated feedback.

Repository: mesos


This makes several changes to the attribute compatibility layer
provided by stout:

  * Add a new `STOUT_HAS_CPP_ATTRIBUTE` macro to test compiler
    support for a given attribute.
  * Renamed the non-namespaced `NORETURN` macro to `STOUT_NORETURN`.
  * Preferred the use of the standardized `[[noreturn]]` syntax
    if supported by the compiler.
  * Fixed previous usages of `NORETURN` in the stout codebase.
  * Added support for the `[[nodiscard]]` attribute.

Diffs (updated)

  3rdparty/stout/include/stout/abort.hpp 43ed5ce2830c493e4c801cc81f8dde0922c99a8d 
  3rdparty/stout/include/stout/attributes.hpp aa377db82e1dbdb8727b1128780e2409accc8ae9 
  3rdparty/stout/include/stout/exit.hpp 34585a005063b17d0c7754c8e8c13f0641383bc4 
  3rdparty/stout/include/stout/unimplemented.hpp ab6caa8fa9645bca66a3efcdc6d337f3fb0481d7

  3rdparty/stout/include/stout/unreachable.hpp d4b3bb0582eb9e64e6f150735d1e9f2956edbca6 





Benno Evers

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message