mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <>
Subject Re: Review Request 71441: Fixed URI stringification.
Date Thu, 19 Sep 2019 05:11:29 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2019, 5:11 a.m.)

Review request for mesos, Gilbert Song and Jie Yu.


Updated commit message.

Summary (updated)

Fixed URI stringification.

Bugs: MESOS-9963

Repository: mesos

Description (updated)

If the caller is not careful to ensure that the path component begins
with '/', stringification of URI objects will concatenate the host and
path, resulting in an malformed URI. The fix is to ensure that these
fuelds are always separated by '/'.

Diffs (updated)

  src/tests/containerizer/docker_spec_tests.cpp 4be0716895132e0406299f7d77f8ceb2d95dbe8a 
  src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 
  src/uri/utils.cpp 3940dc041c1783eec9e7c950402fd7c42e620d8e 




make check (Fedora 30)


James Peach

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message