mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 71516: Refactored framework role tracking logic in the allocator.
Date Thu, 19 Sep 2019 03:30:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71516/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
-------

A framework is tracked under the role if the framework:
(1) is subscribed to the role;
Or
(2) has resources allocated under the role.

(2) could be true without (1). This is because we allow
frameworks to update their roles without revoking their
allocated or offered resources.

This patch recognize this fact and encapsulates the related
checks in the helper.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 5ea37912dadded47eaa2d354889c95533b191c59 
  src/master/allocator/mesos/hierarchical.cpp 256fdce61ccfb768605cac1579c9a6632cd26fec 


Diff: https://reviews.apache.org/r/71516/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message