mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71487: Added method to notify allocator that offered transitioned to allocated.
Date Tue, 17 Sep 2019 22:15:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71487/#review217799
-----------------------------------------------------------




src/master/master.cpp
Lines 5011 (patched)
<https://reviews.apache.org/r/71487/#comment305189>

    `launchResources`? 
    Matches better with `remainingResources`.



src/master/master.cpp
Lines 6133 (patched)
<https://reviews.apache.org/r/71487/#comment305188>

    why the newline? let's minimize unrelated changes.


- Meng Zhu


On Sept. 17, 2019, 6:29 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71487/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2019, 6:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a prerequisite for tracking quota consumption in allocator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 2bab53ab5fb25931a724c20a039e1301983ba574 
>   src/master/allocator/mesos/allocator.hpp 6921581745bf876ee42bcfb62b59245f23fcbf47 
>   src/master/allocator/mesos/hierarchical.hpp 5ea37912dadded47eaa2d354889c95533b191c59

>   src/master/allocator/mesos/hierarchical.cpp 256fdce61ccfb768605cac1579c9a6632cd26fec

>   src/master/master.cpp a2c289a8b6e30eac690f77c7fc1b12b16f62f541 
>   src/tests/allocator.hpp 01e6d2ce3d0655ad408f605c7be84cd7c0f0d479 
> 
> 
> Diff: https://reviews.apache.org/r/71487/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message