mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <>
Subject Re: Review Request 71434: Moved `removeOffers()` from `Master::accept()` into `Master::_accept()`.
Date Fri, 06 Sep 2019 16:55:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 6, 2019, 4:55 p.m.)

Review request for mesos, Benjamin Mahler and Meng Zhu.

Bugs: MESOS-1452 and MESOS-9949

Repository: mesos

Description (updated)

This patch moves offer removal on accept into the deferred continuation
that follows authorization (if offers pass validation in `accept()`).

Incrementing the `offers_accepted` metric is also moved to `_accept()`.

This is a prerequisite for implementing `rescindOffer()` /
`declineOffer()` / in the dependent patch.

Diffs (updated)

  src/master/master.hpp 19c17821d2b8111ebe8e1429a5b4a8423357fdd6 
  src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 





Andrei Sekretenko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message