mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71303: Enabled role sorters to track frameworks.
Date Wed, 28 Aug 2019 05:00:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71303/
-----------------------------------------------------------

(Updated Aug. 27, 2019, 10 p.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Summary (updated)
-----------------

Enabled role sorters to track frameworks.


Bugs: MESOS-9917
    https://issues.apache.org/jira/browse/MESOS-9917


Repository: mesos


Description (updated)
-------

This paves the way for deprecating the framework sorters.

Four new public sorter methods are added:

```
addFramework(role, framework)
removeFramework(role, framework)
contains(framework)
sortFrameworks(role)
```


Diffs (updated)
-----

  src/master/allocator/mesos/sorter/drf/metrics.cpp 82cb5300c5a498d2042562c660a9bd5108158538

  src/master/allocator/mesos/sorter/drf/sorter.hpp f157ec6153325b0457ab1bc76f9eb018712d753a

  src/master/allocator/mesos/sorter/drf/sorter.cpp 09889cdf3dc8c0e773b8e2e24154fb0edd2cc254

  src/master/allocator/mesos/sorter/random/sorter.hpp 8663ccd4ccdd36c8ea7513b492d3f46a0b15ff5c

  src/master/allocator/mesos/sorter/random/sorter.cpp 60a5797472460a8d3d9be938af9f6711ea51d484

  src/master/allocator/mesos/sorter/sorter.hpp 52b8a7b57bf17759311b32aa56c26e614119b773 


Diff: https://reviews.apache.org/r/71303/diff/2/

Changes: https://reviews.apache.org/r/71303/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message