mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71151: Performed periodic storage local provider reconciliations.
Date Mon, 19 Aug 2019 11:59:01 GMT


> On Aug. 9, 2019, 9:41 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 752 (original), 811 (patched)
> > <https://reviews.apache.org/r/71151/diff/4/?file=2159963#file2159963line813>
> >
> >     As commented in the previous patch, since we're having two functions, `reconcileStoragePools`
and `reconcileResources`, it's alright to have a little bit of repeated code and don't introduce
an extra function without a very focused purpose.
> >     
> >     In `reconcileResources`, we could have the logic that checks for `alwaysUpdate`.
In `reconcileStoragePools`, since it's only called when profiles are updated or volumes of
a stale profile are deleted, there's no need for the extra `alwaysUpdate` logic there.

I updated the code in question. I am still not sure I understood what exactly you were after,
could you have a look?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71151/#review217143
-----------------------------------------------------------


On Aug. 19, 2019, 1:58 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71151/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2019, 1:58 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
>     https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Performed periodic storage local provider reconciliations.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072

>   src/tests/storage_local_resource_provider_tests.cpp 69b59d48ceefebbb7accefe411c54ac5cecff1c3

> 
> 
> Diff: https://reviews.apache.org/r/71151/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message