mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 70757: Added docs for the NNP isolator.
Date Wed, 17 Jul 2019 19:25:22 GMT


> On May 31, 2019, 10:31 a.m., Andrei Budnik wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Lines 1098 (patched)
> > <https://reviews.apache.org/r/70757/diff/1/?file=2147137#file2147137line1098>
> >
> >     Can this condition ever be `false`, given the isolator assigns `true` in any
case?
> >     
> >     What is the semantics of `ContainerLaunchInfo::no_new_privileges` flag? How
does it work in pair with the new isolator?
> 
> Jacob Janco wrote:
>     I don't have a default value set in the proto so I think checking here is sane. The
user can set this to false/true explicitly.

Dropping this, feel free to reopen.


- Jacob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70757/#review215611
-----------------------------------------------------------


On July 17, 2019, 7:19 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70757/
> -----------------------------------------------------------
> 
> (Updated July 17, 2019, 7:19 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9770
>     https://issues.apache.org/jira/browse/MESOS-9770
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added docs for the NNP isolator.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 164465a71c660ab9f01fb18d43076afc4b892ad5 
>   docs/isolators/linux-nnp.md PRE-CREATION 
>   docs/mesos-containerizer.md e79976111ec8e9cc8e8d44b5f1b8d6e2c7e072d6 
> 
> 
> Diff: https://reviews.apache.org/r/70757/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message