mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70903: Killed all tasks on the agent when draining.
Date Wed, 10 Jul 2019 19:05:36 GMT


> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote:
> > src/slave/slave.cpp
> > Lines 1010-1016 (patched)
> > <https://reviews.apache.org/r/70903/diff/2/?file=2152205#file2152205line1010>
> >
> >     What about custom executors? :/
> >     
> >     I feel that in general we shouldn't make assumptions  about what certain executors
are doing, and instead introduce our own agent-specific value (best controllable via a flag).
> >     
> >     While you are working on this block you could immediately initialize `killPolicyGracePeriod`
with the default value, and then possibily overwrite it with the user-provided input.
> >     
> >     Note that with your first conditional we would inject the 3s even if a kill
policy was set (to e.g., be interpreted by a custom executor).
> 
> Greg Mann wrote:
>     Maybe the following makes sense:
>     - For the default executor and the command executor, use their default grace period
of 3 seconds when no kill policy was set on the task.
>     - For the Docker executor and custom executors, use the 'executor_shutdown_grace_period'
set on the agent. This is the default grace period used by the Docker executor, and perhaps
also a reasonable default to assume for custom executors?

After some more thought, I think it may be OK to simply pass through the drain max grace period
when it's set and the task grace period is unknown. The worst-case scenario here is that we
would apply a longer grace period than intended, which seems OK.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216192
-----------------------------------------------------------


On July 1, 2019, 7:57 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 7:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70903/diff/3/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message