mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70960: Added test for agent to leave draining state on its own.
Date Fri, 28 Jun 2019 09:27:52 GMT


> On June 28, 2019, 6:05 a.m., Greg Mann wrote:
> > src/tests/slave_tests.cpp
> > Lines 12365-12366 (patched)
> > <https://reviews.apache.org/r/70960/diff/3/?file=2152674#file2152674line12365>
> >
> >     Nit: indentation.

I was using an incorrect `clang-format` (upstream instead of our patched version). I have
reformatted all changes in this chain.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70960/#review216219
-----------------------------------------------------------


On June 28, 2019, 11:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70960/
> -----------------------------------------------------------
> 
> (Updated June 28, 2019, 11:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9860
>     https://issues.apache.org/jira/browse/MESOS-9860
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a test which confirms that the agent leaves a draining
> state on its own once all frameworks on the agent have no more pending
> tasks and all their executors have neither launched or queued tasks.
> 
> The test uses the fact that the agent rejects task launches while
> draining.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 7ba2df9fef9966cd09e0af3f4ef3bb260b6167f6 
> 
> 
> Diff: https://reviews.apache.org/r/70960/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message