mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70966: Test for removing a role from both roles and suppressed roles.
Date Thu, 27 Jun 2019 23:32:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70966/#review216209
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master/update_framework_tests.cpp
Lines 687 (patched)
<https://reviews.apache.org/r/70966/#comment303305>

    Unused?



src/tests/master/update_framework_tests.cpp
Lines 701 (patched)
<https://reviews.apache.org/r/70966/#comment303313>

    Remove newline


- Benjamin Mahler


On June 27, 2019, 7:40 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70966/
> -----------------------------------------------------------
> 
> (Updated June 27, 2019, 7:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9870
>     https://issues.apache.org/jira/browse/MESOS-9870
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test for removing a role from both roles and suppressed roles.
> 
> 
> Diffs
> -----
> 
>   src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f

> 
> 
> Diff: https://reviews.apache.org/r/70966/diff/1/
> 
> 
> Testing
> -------
> 
> without fix: fails
> with fix: `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkTest.RemoveAndUnsuppress*"
--gtest_break_on_failure --gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message