mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 70967: Improved readability of updateFramework() in the hierarchial allocator.
Date Thu, 27 Jun 2019 19:37:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70967/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9870
    https://issues.apache.org/jira/browse/MESOS-9870


Repository: mesos


Description
-------

This patch moves the state-manipulating bits closer together, replaces
the misleading NewRevivedRoles name with NewUnsuppressedRoles and adds
const qualifiers to locals.

This is a prerequisite to fix of MESOS-9870 bug in the next patch.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 26aad6778f12b99bb87c846788d6b6d60f743d8a 


Diff: https://reviews.apache.org/r/70967/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message