mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70901: Added kill policy to the 'Task' message.
Date Thu, 27 Jun 2019 13:06:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70901/#review216191
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Lines 2333 (patched)
<https://reviews.apache.org/r/70901/#comment303266>

    Since this is part of the API, can we add some more documentation?



include/mesos/v1/mesos.proto
Lines 2326 (patched)
<https://reviews.apache.org/r/70901/#comment303267>

    Since this is part of the API, can we add some more documentation?


- Benjamin Bannier


On June 19, 2019, 9 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70901/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 9 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added kill policy to the 'Task' message.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 
>   include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e 
>   src/common/protobuf_utils.cpp 9ff0cf59c658c7c6a3a439a77aff13aff3c20fe5 
> 
> 
> Diff: https://reviews.apache.org/r/70901/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message