mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 70797: Added unit tests for hostname validation.
Date Wed, 26 Jun 2019 00:18:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/
-----------------------------------------------------------

(Updated June 26, 2019, 12:18 a.m.)


Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.


Summary (updated)
-----------------

Added unit tests for hostname validation.


Repository: mesos


Description (updated)
-------

While going through the existing tests to look for candidates
that would benefit from being tested for both hostname validation
schemes, I noticed a number of existing tests where test setup
did not quite match the comment or test name. I fixed these up
in the same review.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/ssl_tests.cpp 6b8496aeeed79ae1bd39d7013f4f403b248fdd4c 


Diff: https://reviews.apache.org/r/70797/diff/4/

Changes: https://reviews.apache.org/r/70797/diff/3-4/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message