mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70917: Refactored the allocator test to use the `updateQuota` method.
Date Mon, 24 Jun 2019 20:30:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70917/#review216110
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/allocator.cpp
Lines 27-34 (original), 27-36 (patched)
<https://reviews.apache.org/r/70917/#comment303104>

    Hm.. could have sworn I commented on this in another review..
    
    Why not just fill in the Quota2 struct directly? Why go through QuotaInfo here?



src/tests/hierarchical_allocator_tests.cpp
Lines 4739 (patched)
<https://reviews.apache.org/r/70917/#comment303103>

    hm.. why is the string needed here? because can't go from ResourceQuantities to Resources?


- Benjamin Mahler


On June 21, 2019, 2:31 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70917/
> -----------------------------------------------------------
> 
> (Updated June 21, 2019, 2:31 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9820
>     https://issues.apache.org/jira/browse/MESOS-9820
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This paves the way to remove `setQuota` and `removeQuota` methods.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator.hpp 765968d5bf9846324d8d7f1d3f6687155c9ea2b5 
>   src/tests/allocator.cpp 553418778350d921f4f1bcec50cd7eeb3a74cc28 
>   src/tests/hierarchical_allocator_benchmarks.cpp 04c124985ac807d13ff09e4142d407d788e66abe

>   src/tests/hierarchical_allocator_tests.cpp 7dc3dc1392b120e2798dcd68f7290cae4afa890d

> 
> 
> Diff: https://reviews.apache.org/r/70917/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message