mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70916: Replaced `Quota` with `Quota2` in the master state.
Date Mon, 24 Jun 2019 18:43:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70916/#review216100
-----------------------------------------------------------




src/master/quota_handler.cpp
Lines 368-374 (original), 368-387 (patched)
<https://reviews.apache.org/r/70916/#comment303093>

    Ditto here, hard for the reader to know why the conversion is here



src/master/quota_handler.cpp
Line 736 (original), 749 (patched)
<https://reviews.apache.org/r/70916/#comment303092>

    Should there be a TODO here? Not quite following why the conversion is needed and authorize
function can't be updated to take the new one



src/master/readonly_handler.cpp
Line 720 (original), 719-720 (patched)
<https://reviews.apache.org/r/70916/#comment303090>

    Maybe grab a const ref to the quota struct at the top of the block here?


- Benjamin Mahler


On June 21, 2019, 2:29 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70916/
> -----------------------------------------------------------
> 
> (Updated June 21, 2019, 2:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9807
>     https://issues.apache.org/jira/browse/MESOS-9807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This paves way to remove `struct Quota`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 7acaa8264eb7a37e17394bc4940971f872ab2de3 
>   src/master/master.cpp d15b2d9dbc79e95c15b689f29f88cebb76f94dd8 
>   src/master/quota_handler.cpp 854189cd052cc88b4dc0ade72c63ac9a1b0bcbb5 
>   src/master/readonly_handler.cpp d62f139ed25dc6d03e91f76bf6574ad8c3c6baa0 
> 
> 
> Diff: https://reviews.apache.org/r/70916/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message