mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 70884: Added optional 'host' string member to UPID.
Date Fri, 21 Jun 2019 22:29:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70884/#review216071
-----------------------------------------------------------




3rdparty/libprocess/src/pid.cpp
Lines 74 (patched)
<https://reviews.apache.org/r/70884/#comment303056>

    Note: I'm a bit unsure about this. On the one hand, it feels super-useful to print UPID's
the same way they were received, and I've been annoyed more often than not that I have to
manually resolve an IP address from some Mesos log.
    
    On the other hand, this can lead to slightly confusing messages like:
    ```
    W0622 00:09:43.911963  5825 slave.cpp:1584] Ignoring re-registration message from master@127.0.1.1:5050
because it is not the expected master: master@localhost:5050
    
    ```
    where it's not immediately obvious that `localhost` is actually ignored by the code in
question and the problem is actually that it resolved to `127.0.0.1` and not `127.0.1.1`.


- Benno Evers


On June 21, 2019, 10:25 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70884/
> -----------------------------------------------------------
> 
> (Updated June 21, 2019, 10:25 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows client code to access the original hostname
> that was used to specify a libprocess address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/pid.hpp 9f09ab46fa3ceaeac09b0fbf9f532728c4ed2d7a

>   3rdparty/libprocess/src/pid.cpp fdc61b5ab6c75b33ce33de7edd11e9302550f300 
>   3rdparty/libprocess/src/process.cpp 799666f03d6a78708aa9336c2dd04bc9b5023aa0 
> 
> 
> Diff: https://reviews.apache.org/r/70884/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message