mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70914: Defined `mapped_type` for `ResourceQuantities` and `ResourceLimits`.
Date Fri, 21 Jun 2019 20:35:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70914/#review216068
-----------------------------------------------------------



This makes the json serialization pretty implicit, why not just add explicit json serialization
functions for these types? I'm not that familiar with the other implications of adding mapped_type,
are you?

- Benjamin Mahler


On June 21, 2019, 2:27 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70914/
> -----------------------------------------------------------
> 
> (Updated June 21, 2019, 2:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This let the two pass the `HasMappedType` and benefit from
> templated functions such as `json`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_quantities.hpp c861df8a8a167b19ea8374c22cdd2a8fe567a6a6 
> 
> 
> Diff: https://reviews.apache.org/r/70914/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message