mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70899: Refactored the agent's task-killing code.
Date Fri, 21 Jun 2019 16:58:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/#review216051
-----------------------------------------------------------


Fix it, then Ship it!




Refactor looks reasonable.  One possible commenting oversight below.


src/slave/slave.cpp
Lines 3782-3784 (patched)
<https://reviews.apache.org/r/70899/#comment303026>

    In the header, the comment says:
    ```
    This function should be used to kill tasks which are queued or launched, but not tasks
which are pending.
    ```
    
    And the refactor seems to prevent this function from being called with a pending task.
 So shouldn't `executor` be non-null?
    
    Or is there some future use-case where this is not true?


- Joseph Wu


On June 19, 2019, 12:05 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70899/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 12:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch factors the code responsible for killing tasks
> out into two helper functions. This will facilitate the
> calling of this common code by the agent-draining handler.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70899/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message