mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70911: Added master endpoints for agent draining.
Date Fri, 21 Jun 2019 13:10:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70911/
-----------------------------------------------------------

(Updated June 21, 2019, 6:10 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
-------

Turns out that you can use proto3 objects in proto2, as long as you include them explicitly.
 So the extra proto file can be removed.

Also added endpoint stubs.


Summary (updated)
-----------------

Added master endpoints for agent draining.


Bugs: MESOS-9814
    https://issues.apache.org/jira/browse/MESOS-9814


Repository: mesos


Description
-------

This adds three master calls:
  * DRAIN_AGENT
  * DEACTIVATE_AGENT
  * REACTIVATE_AGENT

DRAIN_AGENT starts automated draining of tasks on the specified agent.
When marked for draining, the agent's resources will not be offered
and all the agent's tasks will be gracefully killed.

DEACTIVATE_AGENT stops offers for a specific agent.  This can be used
for manual draining of tasks, but is not limited to draining.
For example, tn operator could deactivate an agent prior to
reserving resources.

REACTIVATE_AGENT restarts offers for a specific agent, that had been
drained or deactivated previously.


Diffs (updated)
-----

  include/mesos/master/master.proto 4a653ce59268a47d69362d0e2a3d5eb867ca6fa9 
  include/mesos/v1/master/master.proto d4dd3fcb0abc947097a5a281c4082ccf04db8614 
  src/internal/devolve.hpp fefe86e450fa5083b9ff50e92f4594ffb30a54c8 
  src/internal/devolve.cpp 1d300b49d5cc3de4b8ed409902eb881c7afc07ea 
  src/master/http.cpp 3cd7df228adb54a963821c23b4d1c26d33622ee7 
  src/master/master.hpp 7acaa8264eb7a37e17394bc4940971f872ab2de3 


Diff: https://reviews.apache.org/r/70911/diff/2/

Changes: https://reviews.apache.org/r/70911/diff/1-2/


Testing (updated)
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message