mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70907: Added recovery of agent drain information.
Date Fri, 21 Jun 2019 03:36:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70907/#review216035
-----------------------------------------------------------



Bad review!

Reviews applied: [70907, 70906, 70904, 70903, 70901, 70900, 70899, 70836, 70835, 70834, 70839,
70822]

Error:
2019-06-21 03:36:28 URL:https://reviews.apache.org/r/70907/diff/raw/ [6759/6759] -> "70907.patch"
[1]
error: patch failed: src/slave/state.cpp:203
error: src/slave/state.cpp: patch does not apply

- Mesos Reviewbot


On June 20, 2019, 9:45 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70907/
> -----------------------------------------------------------
> 
> (Updated June 20, 2019, 9:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9822
>     https://issues.apache.org/jira/browse/MESOS-9822
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this patch the agent will, after executor reregistration finished,
> replay any active drain information so remaining tasks are drained as
> well. We need to wait until executors had a chance to register so they
> are not terminated should we try to send kill task request before the
> executor has registered.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
>   src/slave/state.hpp 45836e5805a5038c0b3b5563ea995c3fa90ab808 
>   src/slave/state.cpp b4bf6292eb482f4e99a27442af0ea03e31c1ddc2 
>   src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271 
> 
> 
> Diff: https://reviews.apache.org/r/70907/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message