mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70907: Added recovery of agent drain information.
Date Thu, 20 Jun 2019 21:46:57 GMT


> On June 20, 2019, 5:31 p.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Lines 5639 (patched)
> > <https://reviews.apache.org/r/70907/diff/1/?file=2151419#file2151419line5639>
> >
> >     Are we sure this operation will be idempotent for all executor types?

The way this test is written we are more checking the agent's behavior and less that of executors,
i.e., agent resumes draining if it fails over after receiving a drain request.

That being said, the test here uses a `MockExecutor` which currently only instantiated for
`MesosContainerizer`. Testing multiple containerizers doesn't seem that interesting here.

Moved this to `SlaveTest`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70907/#review216003
-----------------------------------------------------------


On June 20, 2019, 11:45 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70907/
> -----------------------------------------------------------
> 
> (Updated June 20, 2019, 11:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9822
>     https://issues.apache.org/jira/browse/MESOS-9822
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this patch the agent will, after executor reregistration finished,
> replay any active drain information so remaining tasks are drained as
> well. We need to wait until executors had a chance to register so they
> are not terminated should we try to send kill task request before the
> executor has registered.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
>   src/slave/state.hpp 45836e5805a5038c0b3b5563ea995c3fa90ab808 
>   src/slave/state.cpp b4bf6292eb482f4e99a27442af0ea03e31c1ddc2 
>   src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271 
> 
> 
> Diff: https://reviews.apache.org/r/70907/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message