mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 70911: WIP: Added master endpoints for agent draining.
Date Thu, 20 Jun 2019 21:01:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70911/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.


Bugs: MESOS-9814
    https://issues.apache.org/jira/browse/MESOS-9814


Repository: mesos


Description
-------

This adds three master calls:
  * DRAIN_AGENT
  * DEACTIVATE_AGENT
  * REACTIVATE_AGENT

DRAIN_AGENT starts automated draining of tasks on the specified agent.
When marked for draining, the agent's resources will not be offered
and all the agent's tasks will be gracefully killed.

DEACTIVATE_AGENT stops offers for a specific agent.  This can be used
for manual draining of tasks, but is not limited to draining.
For example, tn operator could deactivate an agent prior to
reserving resources.

REACTIVATE_AGENT restarts offers for a specific agent, that had been
drained or deactivated previously.


Diffs
-----

  include/google/duration.proto PRE-CREATION 
  include/mesos/master/master.proto 4a653ce59268a47d69362d0e2a3d5eb867ca6fa9 
  include/mesos/v1/master/master.proto d4dd3fcb0abc947097a5a281c4082ccf04db8614 
  src/CMakeLists.txt 1d4f541b73c07a307a8b61f217e0cfad5dc095e4 


Diff: https://reviews.apache.org/r/70911/diff/1/


Testing
-------

make check

TODO: Has the hacky google Duration object thing included, which is not pretty...
TODO: Missing autotools build modification.
TODO: Should also add the relevant endpoints, since the patch would generate warnings otherwise
(because new switch cases are not being handled).


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message