mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 70795: Updated SSL docs to include new libprocess flag.
Date Thu, 20 Jun 2019 17:29:45 GMT


> On June 20, 2019, 1:05 p.m., Jan-Philip Gehrcke wrote:
> > docs/ssl.md
> > Lines 145 (patched)
> > <https://reviews.apache.org/r/70795/diff/2/?file=2151355#file2151355line145>
> >
> >     "via DNS name" instead of "via hostname"?

I know that "DNS name" is more common in the context of x509 certification, but here I think
it may be confusing for readers: It's the first only time a "DNS name" is mentioned in this
document, and also there's no requirement that the DNS name must be resolved via DNS or stored
in any DNS server.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70795/#review215998
-----------------------------------------------------------


On June 20, 2019, 5:27 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70795/
> -----------------------------------------------------------
> 
> (Updated June 20, 2019, 5:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jan-Philip Gehrcke, Joseph Wu, and Till
Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a description of the new `--hostname_validation_algorithm` flag
> and corresponding `LIBPROCESS_SSL_HOSTNAME_VALIDATION_ALGORITHM`
> environment variable.
> 
> 
> Diffs
> -----
> 
>   docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c 
> 
> 
> Diff: https://reviews.apache.org/r/70795/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message