mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70907: WIP: Added recovery of agent drain information.
Date Thu, 20 Jun 2019 15:31:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70907/#review216003
-----------------------------------------------------------




src/slave/slave.cpp
Lines 5639 (patched)
<https://reviews.apache.org/r/70907/#comment302940>

    Are we sure this operation will be idempotent for all executor types?



src/tests/slave_recovery_tests.cpp
Lines 5335 (patched)
<https://reviews.apache.org/r/70907/#comment302941>

    Nit: not indented far enough.



src/tests/slave_recovery_tests.cpp
Lines 5338 (patched)
<https://reviews.apache.org/r/70907/#comment302942>

    s/Ince/Once/


- Greg Mann


On June 20, 2019, 1:30 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70907/
> -----------------------------------------------------------
> 
> (Updated June 20, 2019, 1:30 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9822
>     https://issues.apache.org/jira/browse/MESOS-9822
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With this patch the agent will, after executor reregistration finished,
> replay any active drain information so remaining tasks are drained as
> well. We need to wait until executors had a chance to register so they
> are not terminated should we try to send kill task request before the
> executor has registered.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
>   src/tests/slave_recovery_tests.cpp d99752ab082f1aca9fb77659378d0bca5a0598eb 
> 
> 
> Diff: https://reviews.apache.org/r/70907/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message