mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan-Philip Gehrcke via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 70795: Updated SSL docs to include new libprocess flag.
Date Thu, 20 Jun 2019 13:05:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70795/#review215998
-----------------------------------------------------------


Fix it, then Ship it!




Great work, left a few comments. Thanks!


docs/ssl.md
Lines 132 (patched)
<https://reviews.apache.org/r/70795/#comment302930>

    Let's maybe call this VALIDATION_SCHEME instead of VALIDATION_ALGORITHM



docs/ssl.md
Lines 142 (patched)
<https://reviews.apache.org/r/70795/#comment302934>

    backticks around `openssl`?



docs/ssl.md
Lines 145 (patched)
<https://reviews.apache.org/r/70795/#comment302931>

    "via DNS name" instead of "via hostname"?



docs/ssl.md
Lines 147 (patched)
<https://reviews.apache.org/r/70795/#comment302932>

    Even if this consumes a little more space let's make clear what happens when `LIBPROCESS_SSL_VERIFY_IPADD`
is false 
    
    (IIUC then the TLS handshake will fail when we use IP addresses for opening the connection)



docs/ssl.md
Lines 150 (patched)
<https://reviews.apache.org/r/70795/#comment302933>

    "Don't"
    or
    "Do not"



docs/ssl.md
Lines 154 (patched)
<https://reviews.apache.org/r/70795/#comment302935>

    backticks?



docs/ssl.md
Lines 177 (patched)
<https://reviews.apache.org/r/70795/#comment302936>

    Great!


- Jan-Philip Gehrcke


On June 19, 2019, 2:46 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70795/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 2:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jan-Philip Gehrcke, Joseph Wu, and Till
Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a description of the new `--hostname_validation_algorithm` flag
> and corresponding `LIBPROCESS_SSL_HOSTNAME_VALIDATION_ALGORITHM`
> environment variable.
> 
> 
> Diffs
> -----
> 
>   docs/ssl.md ce5058896144aa7824986d40d996899d92cb7c1c 
> 
> 
> Diff: https://reviews.apache.org/r/70795/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message