mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
Date Thu, 20 Jun 2019 05:56:52 GMT


> On June 20, 2019, 8:44 a.m., Gilbert Song wrote:
> > include/mesos/mesos.proto
> > Lines 3269-3270 (patched)
> > <https://reviews.apache.org/r/70775/diff/1/?file=2147578#file2147578line3269>
> >
> >     delete: with a possibility to share them with its child containers
> >     
> >     Is a nested container allowed to have its own ipc namespace and /dev/shm?

I would suggest to keep `"with a possibility to share them with its child containers"`, actually
Docker has something similar, see `--ipc=shareable` in https://docs.docker.com/engine/reference/run/#ipc-settings---ipc

> Is a nested container allowed to have its own ipc namespace and /dev/shm?

Yes.


> On June 20, 2019, 8:44 a.m., Gilbert Song wrote:
> > include/mesos/mesos.proto
> > Lines 3279 (patched)
> > <https://reviews.apache.org/r/70775/diff/1/?file=2147578#file2147578line3279>
> >
> >     s/do it/ share from the agent's/g

The word `share from the agent's` makes the whole sentence a bit redundant, so I would suggest
to keep the word `do it`.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215974
-----------------------------------------------------------


On June 7, 2019, 7:23 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70775/
> -----------------------------------------------------------
> 
> (Updated June 7, 2019, 7:23 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9827
>     https://issues.apache.org/jira/browse/MESOS-9827
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d 
>   include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44 
> 
> 
> Diff: https://reviews.apache.org/r/70775/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message