mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 70775: Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
Date Thu, 20 Jun 2019 00:44:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70775/#review215974
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Lines 3269-3270 (patched)
<https://reviews.apache.org/r/70775/#comment302899>

    delete: with a possibility to share them with its child containers
    
    Is a nested container allowed to have its own ipc namespace and /dev/shm?



include/mesos/mesos.proto
Lines 3273 (patched)
<https://reviews.apache.org/r/70775/#comment302893>

    s/with/from/g



include/mesos/mesos.proto
Lines 3275 (patched)
<https://reviews.apache.org/r/70775/#comment302894>

    s/with/from/g



include/mesos/mesos.proto
Lines 3277 (patched)
<https://reviews.apache.org/r/70775/#comment302895>

    ditto



include/mesos/mesos.proto
Lines 3278 (patched)
<https://reviews.apache.org/r/70775/#comment302896>

    ditto



include/mesos/mesos.proto
Lines 3279 (patched)
<https://reviews.apache.org/r/70775/#comment302897>

    s/do it/ share from the agent's/g



include/mesos/mesos.proto
Lines 3289 (patched)
<https://reviews.apache.org/r/70775/#comment302907>

    period `.` at the end.



include/mesos/mesos.proto
Lines 3290-3294 (patched)
<https://reviews.apache.org/r/70775/#comment302908>

    Can we split into different sentences to make it more clear?



include/mesos/mesos.proto
Lines 3296 (patched)
<https://reviews.apache.org/r/70775/#comment302909>

    s/handling/support/g



include/mesos/mesos.proto
Lines 3297 (patched)
<https://reviews.apache.org/r/70775/#comment302910>

    s/,/./g



include/mesos/mesos.proto
Lines 3299-3301 (patched)
<https://reviews.apache.org/r/70775/#comment302911>

    add `()` to i.e.,...



include/mesos/v1/mesos.proto
Lines 3259 (patched)
<https://reviews.apache.org/r/70775/#comment302912>

    ditto


- Gilbert Song


On June 6, 2019, 4:23 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70775/
> -----------------------------------------------------------
> 
> (Updated June 6, 2019, 4:23 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9827
>     https://issues.apache.org/jira/browse/MESOS-9827
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `ipc_mode` and `shm_size` fields into `LinuxInfo`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d 
>   include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44 
> 
> 
> Diff: https://reviews.apache.org/r/70775/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message