mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.
Date Thu, 13 Jun 2019 12:17:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70834/#review215872
-----------------------------------------------------------



Are you planning to add the recovery logic later?  (That would fit nicely into this patch)


src/slave/state.proto
Lines 35-39 (patched)
<https://reviews.apache.org/r/70834/#comment302817>

    This shouldn't be necessary.  You can just add an `Optional<DrainInfo>` field into
`src/slave/state.hpp`
    ```
    ...
    struct SlaveState
    {
      ...
      SlaveID id;
      Option<SlaveInfo> info;
      Optional<DrainInfo> drainInfo;
      ...
    }
    ```
    
    The checkpointing code above is saving the DrainInfo directly, without wrapping it in
this object.


- Joseph Wu


On June 12, 2019, 1:11 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70834/
> -----------------------------------------------------------
> 
> (Updated June 12, 2019, 1:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9818
>     https://issues.apache.org/jira/browse/MESOS-9818
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a minimal handler to the agent for the
> `DrainSlaveMessage`. This handler will later be extended
> to implement the full functionality.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp ad768267e6a3c105eab4b36b05351d175d720eaf 
>   src/slave/paths.cpp 1163c88eefd2a9e99b56817a3f515a23ee6e3903 
>   src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
>   src/slave/state.proto 2bdf691026f1ee9f341411b4b2942368212ccfd3 
> 
> 
> Diff: https://reviews.apache.org/r/70834/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message