mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70814: Replaced a set of single '*' role in SCRIPT_TEST ACL with ANY.
Date Wed, 12 Jun 2019 16:34:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70814/
-----------------------------------------------------------

(Updated June 12, 2019, 4:34 p.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-----------------

Replaced a set of single '*' role in SCRIPT_TEST ACL with ANY.


Repository: mesos


Description (updated)
-------

This patch changes the roles set in the ACL used by SCRIPT_TESTs for the
`register_frameworks` action from a single wildcard role (which is not
treated by the local authorizer in any special way, i.e. only wildcard
is allowed) to `ANY`. This is needed for adding and removing roles via
the UPDATE_FRAMEWORK call in `ExamplesTest`s.


Diffs (updated)
-----

  src/tests/script.cpp 2e50861bf40ceeaf6a40476a742e6e82c23ba86f 


Diff: https://reviews.apache.org/r/70814/diff/2/

Changes: https://reviews.apache.org/r/70814/diff/1-2/


Testing
-------

make check

NOTE: without this change it is not possible to subscribe the java example framework with
a role/roles other than `*`


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message